Allow text values in JCAMP files without brackets#100
Merged
Conversation
Allow text values in JCAMP files which aren't surrounded by angle brackets. Remove angle brackets only if they indeed surround the value. Try parsing the value to numerical types, and return a string if parsing fails.
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow text values in JCAMP files which aren't surrounded by angle
brackets. Remove angle brackets only if they indeed surround the value.
Try parsing the value to numerical types, and return a string if parsing
fails.
Although I didn't read the JCAMP specification, a quick look at JCAMP for NMR (1993), Example 4 makes me believe that the angle brackets are not required for text values.