Better proc_autophase.py#124
Conversation
…n-friendly error message when a wrong key passed passed
|
@kivicode, this looks like a good addition when phasing the data with either too many peaks, or when the data itself is small. The only comment I have is to switch the position of the There is the question of having an algorithm-specific argument in the general |
|
@kaustubhmote Yeah, you're right, I'll swap them. And how about making a separate dict or tuple variable, that will receive all the additional arguments to pass to For example: |
|
This looks like a nice solution to me. However, a dictionary wont work, at least for Python < 3.6, since the order is not conserved (and since the |
|
Thanks for putting this together @kivicode and for the review @kaustubhmote. This looks like a good change to me. I agree with @kaustubhmote comments that dealing with algorithms specific arguments in |
Peak width parameter for "peak_minima" phase correction and more human-friendly error message when a wrong key passed.