Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PY3: changes not suggested by pyupgrade#179

Merged
jjhelmus merged 1 commit into
jjhelmus:masterfrom
DimitriPapadopoulos:PY3
Dec 6, 2022
Merged

PY3: changes not suggested by pyupgrade#179
jjhelmus merged 1 commit into
jjhelmus:masterfrom
DimitriPapadopoulos:PY3

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

No description provided.

@jjhelmus
Copy link
Copy Markdown
Owner

jjhelmus commented Dec 6, 2022

LGTM

@jjhelmus jjhelmus merged commit 7c697cb into jjhelmus:master Dec 6, 2022
@kaustubhmote
Copy link
Copy Markdown
Collaborator

This merge may need to be partially reverted. xcpy module works within Topspin with Jython rather than CPython, which is why the antiquated style/features of Python 2.7 is used everywhere.

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

DimitriPapadopoulos commented Dec 7, 2022

I just discovered that Jython only supports Python 2. Given the pace of change of Python libraries, I guess this means Jython is more or less dead. Any way, since the xcpy module works within TopSpin which includes Jython, there is no discussion here: I will revert xcpy.py and xcpy_test.py changes. Sorry about the mess.

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

BTW, I got confused by setup.py:

        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.6',
        'Programming Language :: Python :: 3.7',
        'Programming Language :: Python :: 3.8',
        'Programming Language :: Python :: 3.9',

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

Reverted in #183.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants