Fix JCAMP-DX block reading#191
Merged
Merged
Conversation
Collaborator
|
Thanks, this looks good. I am merging this in now. Apologies for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JCAMP-DX parser was a bit flawed what comes to the JCAMP "block" structuring i.e. separating data sections (of different ##DATATYPEs). The blocks should always start at ##TITLE tag (this was not respected), end to ##END tag and they may also be nested (also did not work). This PR fixes the block reading as it is specified.
Some additional notes:
_getdataarrayfunction was renamed togetdataarrayas it is needed to be called from outside the parser as well.dicstructure2.zip