Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix JCAMP-DX block reading#191

Merged
kaustubhmote merged 1 commit into
jjhelmus:masterfrom
JLVarjo:jcampdx-block-fix
Jun 14, 2023
Merged

Fix JCAMP-DX block reading#191
kaustubhmote merged 1 commit into
jjhelmus:masterfrom
JLVarjo:jcampdx-block-fix

Conversation

@JLVarjo
Copy link
Copy Markdown
Contributor

@JLVarjo JLVarjo commented Feb 20, 2023

The JCAMP-DX parser was a bit flawed what comes to the JCAMP "block" structuring i.e. separating data sections (of different ##DATATYPEs). The blocks should always start at ##TITLE tag (this was not respected), end to ##END tag and they may also be nested (also did not work). This PR fixes the block reading as it is specified.

Some additional notes:

@kaustubhmote kaustubhmote merged commit 0d19837 into jjhelmus:master Jun 14, 2023
@kaustubhmote
Copy link
Copy Markdown
Collaborator

Thanks, this looks good. I am merging this in now. Apologies for the delay.

@JLVarjo JLVarjo deleted the jcampdx-block-fix branch March 26, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants