Changed 'np.float' to 'float' in peakpick.py line 329#193
Merged
Conversation
This was referenced Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed 'np.float' to 'float' in peakpick.py line 329 to fix the np.analysis.peakpick.pick() function. NumPy deprecated the np.float function in numpy 1.20.0 which broke the ng.analysis.peakpick.pick() function giving an error (see nmrglue issue #192). Changing 'np.float' to 'float' is the recommended fix by NumPy as it "will not modify any behavior and is safe." Using the float() function instead of np.float() looks to be consistent with the rest of the code in peakpick.py.