BugFix: directory variable in read_vdlist#213
Merged
Conversation
cleanup of error message added a test for reading vdlist
kaustubhmote
added a commit
to kaustubhmote/nmrglue
that referenced
this pull request
Feb 21, 2025
…jhelmus#213) Fixed a bug related to directory variable in read_vdlist in fileio/bruker.py Cleanup of error message Added a test for reading vdlist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I somehow missed that the final version of PR #212 had a bug in directory variable name. I am fixing this, as well as adding a test to check this function. Plus some cleanup of the error message.