Fixed deprecations for Symfony 4.3+#21
Conversation
|
@SvetlinStaev: Thanks for the contribution. Was AutoLoginListener the only file still using deprecated classes throughout the library? On a side note, will this PR require changes to composer.json? I assume Symfony 2.0 and 3.0 may no longer be supported with this change. |
Updated composer constraints to match Symfony 4.3 Updated composer library version since the changes break compat with Symfony 2 and 3 Added typehints where possible
|
@jmikola, I push some changes to fix an event dispatcher change and updated composer to reflect that these changes should be best suited for 4.3+ of Symfony which also ups the PHP min requirement to 7.1. |
jmikola
left a comment
There was a problem hiding this comment.
@SvetlinStaev Thanks for putting the effort into this PR. I have just a couple of questions but I think this is overall in good shape to merge and release. Happy to address the outstanding todo items myself if you'd just like to follow up on the questions.
| public function authenticate(TokenInterface $token) | ||
| { | ||
| if (!$this->supports($token)) { | ||
| if (!$token instanceof AutoLoginToken || !$this->supports($token)) { |
There was a problem hiding this comment.
I'll remove this before merging, as this check is already done in the supports() method.
|
Manually squashed and merged in 055912a. Thanks! |
|
2.0.0 has been tagged and includes this PR. |
This is a PR which updates the library to support the Symfony 4.3 without any deprecations. Also removing some unused security interfaces deprecated since Symfony 3.