Prevent spurious cache clearing when calling a cached func inside a Parallel call - #1093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
- Coverage 94.52% 93.91% -0.62%
==========================================
Files 47 47
Lines 6910 6955 +45
==========================================
Hits 6532 6532
- Misses 378 423 +45
Continue to review full report at Codecov.
|
|
@ogrisel feel free to take a look, this is reviewable :) |
| # an environement where the introspection utilitiees get_func_code | ||
| # relies on do not work (typicially, in joblib child processes). | ||
| # See #1035 for more info | ||
| # TODO (pierreglaser): do the same with get_func_name? |
There was a problem hiding this comment.
That's a good question. It does not seem to be required to fix #1035 though (I tried manually with the reproducer in an interactive ipython session).
There was a problem hiding this comment.
I also tried to stop and restart the ipython session and the cache survived.
|
Thank you very much @pierreglaser . Actually, I forgot to update the changelog prior to merging this. I will do it now. |
Fixes #1035
cc @ogrisel - I need to test a few more cases, but it should be reviewable.