MNT remove python 3.9 from CI - #1773
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 94.13% 93.99% -0.14%
==========================================
Files 46 46
Lines 7979 7979
==========================================
- Hits 7511 7500 -11
- Misses 468 479 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lesteve
left a comment
There was a problem hiding this comment.
Thanks for the PR, some comments.
I think ignore this one for now, code in Also |
|
With |
There was a problem hiding this comment.
This looks nice!
To finish this, we need:
- add an entry in the changelog
- Maybe add in doc our strategy for supporting the libraries (numpy, distributed). Also write somewhere the current oldest supported version.
- add in
doc/developping.rstsome info on how to update these tests so we have a consistent way to do this (we need to do this every year).
tomMoral
left a comment
There was a problem hiding this comment.
A first batch of comments
| name: [default] | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| PYTHON_VERSION: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| PYTHON_VERSION: ["OLD", "3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
| PYTHON_VERSION: ["OLD", "3.11", "3.12", "3.13", "3.14"] | |
| PYTHON_VERSION: ["3.10", "3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
Let's keep this one explicit as this tests the range with the latest installable libraries
There was a problem hiding this comment.
In commit 98dcb90, I put both "oldest_supported" and "3.10" in order to test the oldest python version with both oldest and latest versions of numpy and cloudpickle.
| elif [[ $PYTHON_VERSION == "OLD" ]]; then | ||
| PYTHON_VERSION=$PYTHON_OLD_VERSION | ||
| CLOUDPICKLE="cloudpickle==$CLOUDPICKLE_OLD_VERSION" | ||
| NUMPY="numpy==$NUMPY_OLD_VERSION" |
There was a problem hiding this comment.
But we want to also try oldest python with latest numpy supported for this version (which is for new install).
So not sure I like this coupling here. I think I prefered the explicit extra_conda_packages
There was a problem hiding this comment.
With commit 98dcb90, we now test oldest python with both oldest versions and latest version of numpy.
The goal was to make easier the change of supported versions by just modifying values at one place (the environment variables in test.yml).
Does it look better to you now?
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Loïc Estève <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
lesteve
left a comment
There was a problem hiding this comment.
Looks good enough for me, let's merge this one!
Removing Python 3.9 from CI.
In cloudpickle.py
_code_reducefunction, there is some code for python 3.9 or older. Should we remove it?Closes #1766