MNT unvendor cloudpickle - #1775
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 94.23% 94.20% -0.03%
==========================================
Files 46 46
Lines 7922 7922
==========================================
- Hits 7465 7463 -2
- Misses 457 459 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomMoral
reviewed
Jan 30, 2026
tomMoral
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR.
The code looks ok like this (not too complicated).
Now we need:
- add a CI with the oldest supported version of cloudpickle (I think we said two year support is ok), the latest and the dev version on all plateforms.
- add a changelog entry
tomMoral
reviewed
Feb 2, 2026
tomMoral
left a comment
Contributor
There was a problem hiding this comment.
A few more comments but otherwise, it starts to look good.
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
lesteve
reviewed
Feb 5, 2026
lesteve
reviewed
Feb 5, 2026
Co-authored-by: Loïc Estève <[email protected]>
Member
|
Let's merge this one, thanks! |
3 tasks
thomass-dev
added a commit
to thomass-dev/skrub-fork
that referenced
this pull request
Sep 7, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried unvendoring cloudpickle but now many tests fail on one computer. On another computer, less tests are failing. I'm already creating a PR just to see the behavior in the CI.
Closes: #1753
Closes: #838