FIX forward mmap_mode to store backend in MemorizedResult - #1799
Merged
Conversation
MemorizedResult accepted mmap_mode but never passed it to _store_backend_factory, so a result reconstructed from a location loaded cached arrays fully into memory instead of memory-mapping them, even when mmap_mode was requested. MemorizedFunc already forwards it via backend_options. Add a regression test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 94.19% 94.17% -0.02%
==========================================
Files 46 46
Lines 7926 7936 +10
==========================================
+ Hits 7466 7474 +8
- Misses 460 462 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM, thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemorizedResulttakes anmmap_modeargument but never passes it to its store backend._store_backend_factoryis called withoutbackend_options, so the backend keepsmmap_mode=Noneandload_itemloads arrays fully into memory even whenmmap_mode="r"was requested.MemorizedFuncalready forwards it the same way (viabackend_options).So reconstructing a cached result from a location and asking for mmap gives you a plain array instead of a memmap:
The fix forwards
mmap_modeto the factory, matchingMemorizedFunc. Added a regression test. Fulltest_memory.pypasses (68),ruffclean.