MNT vendor loky 3.6.0 - #1843
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 94.06% 94.05% -0.02%
==========================================
Files 46 46
Lines 8070 8070
==========================================
- Hits 7591 7590 -1
- Misses 479 480 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
larsoner
added a commit
to larsoner/joblib
that referenced
this pull request
Sep 1, 2026
Conflict in joblib/externals/loky/backend/resource_tracker.py: loky 3.6.0 (joblib#1843) rewrote the tracker to subclass the stdlib 3.14 ResourceTracker and carries the Windows teardown fix this branch had vendored by hand -- keeping the process handle from CreateProcess and waiting on it instead of the pid. Upstream's version is a superset (it also records the exit code and handles the wait timeout), so the file is taken verbatim from upstream and the local vendoring dropped. joblib/externals/loky/process_executor.py merged cleanly; the two patches still not upstream (LOKY_MAX_MEMORY_LEAK_SIZE and the _RecycledWorkerPid one-shot recycling warning) are preserved on top of 3.6.0. CHANGES.rst: 1.6.0 was released upstream in the meantime, so the temporary folder registration entry is moved from that now-frozen section into "In Development" and gets its PR link. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01MuosJL7XVWuB6bEczRsE9v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the part of
vendor_loky.shthat was changing thecloudpickleimports, since we are no longer vendoringcloudpickle.