[MRG+1] Fix format_stack with compiled code (e.g. .so or .pyd) in the traceback - #382
Merged
aabadie merged 1 commit intoAug 1, 2016
Merged
Conversation
Contributor
|
@lesteve, in case you missed it, tests are broken on Travis under Python 3.3. |
lesteve
force-pushed
the
fix-format-stack-with-compiled-code
branch
2 times, most recently
from
July 29, 2016 05:28
9fe1751 to
2674adc
Compare
Contributor
|
All green +1 |
Member
Author
|
I forgot to add a comment about the addition of SyntaxError in the code, I'll do that soonish. |
Contributor
Ok, let me know when it's done. |
lesteve
force-pushed
the
fix-format-stack-with-compiled-code
branch
from
July 29, 2016 13:01
2674adc to
18f7fad
Compare
lesteve
force-pushed
the
fix-format-stack-with-compiled-code
branch
from
July 29, 2016 15:37
18f7fad to
90deace
Compare
Member
Author
|
@aabadie I added the aforementioned comment and an entry in CHANGES.rst. |
Contributor
|
LGTM, merging. Thanks ! |
Contributor
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Took the fix from IPython.core.ultratb.py