Add edit, audio, and moderation APIs to client abstraction #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanste
reviewed
Jun 22, 2023
| top_p: float = ..., | ||
| **kwargs, | ||
| ): | ||
| self._populate_args( |
There was a problem hiding this comment.
It is a bit of an annoying pattern to have to do this dance. But any "magic" (e.g. decorator) would not be significantly simpler. It might be possible to inspect the decorated function and use annotations to avoid the duplication of signatures across, but that does feel pri3:ish.
johanste
reviewed
Jun 22, 2023
johanste
reviewed
Jun 22, 2023
johanste
reviewed
Jun 22, 2023
johanste
reviewed
Jun 22, 2023
Co-authored-by: Johan Stenberg (MSFT) <[email protected]>
Co-authored-by: Johan Stenberg (MSFT) <[email protected]>
Co-authored-by: Johan Stenberg (MSFT) <[email protected]>
Co-authored-by: Johan Stenberg (MSFT) <[email protected]>
johanste
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.