Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added patch versions for angular packages #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added patch versions for angular packages #163

wants to merge 1 commit into from

Conversation

listepo-alterpost
Copy link

Purpose

Fix npm WARN [email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@listepo-alterpost
Copy link
Author

@johnpapa or @wardbell can you make a review?

@wardbell
Copy link
Collaborator

wardbell commented Jul 3, 2018

You're right! But why ~ instead of the more forgiving ^? I think we should be fine with Angular changes that are non-breaking (less than major version number).

See https://stackoverflow.com/questions/22343224/whats-the-difference-between-tilde-and-caret-in-package-json

I want to get this in right away so I'm going with ^6.0.0 in the beta.9 release, arriving any minute.

Thanks for catching this.

wardbell added a commit that referenced this pull request Jul 3, 2018
@wardbell
Fixes: beta.9
9d35800 
closes #163, 165
* Critical: data service update should send entity data, not Update<T> #165
* Allow Angular peer dependencies to update within v.6
See ChangeLog
wardbell added a commit that referenced this pull request Jul 3, 2018
@wardbell
Fixes: beta.9
7742423 
closes #163, 165
* Critical: data service update should send entity data, not Update<T> #165
* Allow Angular peer dependencies to update within v.6
See ChangeLog
@wardbell wardbell closed this in 72d133b Jul 3, 2018
@wardbell wardbell mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@listepo-alterpost @wardbell