Expiremental: add a section output to track current running command #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0cd06d to
f40bf64
Compare
pyrech
approved these changes
Aug 16, 2023
| @@ -49,14 +49,19 @@ public static function getInput(): InputInterface | |||
| return self::$input ?? throw new \LogicException('Input not available yet.'); | |||
| } | |||
|
|
|||
| public static function setOutput(OutputInterface $output): void | |||
There was a problem hiding this comment.
Should the removal of this setter be considered as a BC-break?
There was a problem hiding this comment.
maybe, but imo GlobalHelper is mainly used internally, maybe we should declare it like that instead ?
There was a problem hiding this comment.
That's what I thought at first but then remembered that we offered some setter to configure the app globally like for the cache, logger or http client, so probably not so internal IMO
There was a problem hiding this comment.
Maybe have custom function instead of using that then ? This class have both external / internal public methods from what i see, we should avoid that and provide a clean external entrypoint for this behavior, but not the subject of this PR,
54b11bb to
1c37af8
Compare
1c37af8 to
9e4a628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new way to output log for castor which will do the following :
Currently this output is only available when using the
CASTOR_USE_SECTION=trueenv variable, we can make this default later, but it will be better to first test this output and existing project as an expiremental approach so we can iterate on this with real use casetest-2023-08-11_18.08.05.webm
Need symfony/symfony#51355 to work
Need symfony/symfony#51378 for better output (too many new lines)