Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Ercogx
Copy link
Contributor

@Ercogx Ercogx commented Feb 27, 2025

Discussed it on #177

Changes:

  • Updated CURSOR_PAGINATION constant.
  • Added a docblock for the virtual method.
  • Wrote tests to verify pagination methods.
  • Removed Note: the virtual methods are not yet documented ... from the docs.

@damienalexandre
Copy link
Member

damienalexandre commented Feb 27, 2025

Hum the Check SDK is in sync with spec test is failing, but that's on us I think main is not up to date with the latest Jane updates.

The Check Coding Standards test can be fixed on your side by running PHP CS Fixer (make cs).

@damienalexandre
Copy link
Member

damienalexandre commented Feb 27, 2025

I fixed main, so you case rebase, run make cs and push 👍

#179

Thanks!

Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@Ercogx
Copy link
Contributor Author

Ercogx commented Feb 27, 2025

There is a problem with the tests - testItCanUploadFile returns a deprected error. I can make another PR for this

https://api.slack.com/methods/files.upload

@damienalexandre
Copy link
Member

There is already a PR about the upload situation, if you want to jump in! :-) Thanks a lot for your contribution!

#176

@damienalexandre damienalexandre merged commit 9535f16 into jolicode:main Feb 27, 2025
6 checks passed
@damienalexandre
Copy link
Member

When we merge on "main" tests are run on a real Slack API and it looks like one method fail:

https://github.com/jolicode/slack-php-api/actions/runs/13564828905/job/37915496874

1) JoliCode\Slack\Tests\ClientTest::testAllCursorPaginationMethodExists
JoliCode\Slack\Exception\SlackErrorResponse: Slack returned error code "missing_scope"

The only added method is https://api.slack.com/methods/usergroups.list so we probably need to add usergroups:read to our token.

I will have a look later.

@Ercogx
Copy link
Contributor Author

Ercogx commented Feb 27, 2025

I think that the problem is this, here's a list of scopes for my test apps. I thought about CONTRIBUTING.md could be updated where to add describe the process to run the tests

image

@damienalexandre
Copy link
Member

Tests are green now I added the missing scope and updated the documentation.

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants