Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added support for immutable processing #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

sdellysse
Copy link
Collaborator

I needed to run this lib against an array that I should not modify. I added a new function unique.immutable that keeps all semantics of unique except it doesn't modify the input array. Performance will be slightly lessened but not enough to matter in my case.

@sdellysse
Copy link
Collaborator Author

ping

@jonschlinkert
Copy link
Owner

Hi, thanks for the pr @shawndellysse, sorry I didn't see this earlier. I'll take asap, thanks!

@sdellysse
Copy link
Collaborator Author

Thanks!

@jonschlinkert
Copy link
Owner

Really sorry for the extremely late merge!

@jonschlinkert jonschlinkert merged commit d087495 into jonschlinkert:master Aug 1, 2016
@jonschlinkert
Copy link
Owner

@shawndellysse this was a superb pr. Comprehensive tests, beautifully coded, docs as well. I really appreciate it, and again I'm sorry it took so long.

Also, I made you a collab on this lib. I'd be happy to add you to npm as well if you want to give me your username. thanks again!

@jonschlinkert
Copy link
Owner

almost forgot, published and git tagged as 0.3.2. Since there were no changes to the existing API, a patch should be fine

@es128
Copy link

es128 commented Aug 1, 2016

Hey @jonschlinkert - happened to come across this following your tweet about it.

Hopefully this isn't overly pedantic, but if you want to follow the semver spec it seems like this should have been a minor version bump, which indicates feature additions with no breaking changes to the existing API. Patches are supposed to indicate bug fixes with no changes to the api footprint.

Otoh technically you're fine since anything goes in the 0.x range.

Just thought it was worth a quick mention to help guide any future semver decisions.

@jonschlinkert
Copy link
Owner

You're absolutely right. I guess I'm slipping into absentmindedness.

Glad to see you btw, I was just wondering how you were doing

@es128
Copy link

es128 commented Aug 1, 2016

Doing fine, just spending more time on other hobbies lately.

Hope all is well with you 😀

@jonschlinkert
Copy link
Owner

good to hear. yeah I'm doing well, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants