fix potential prototype pollution#12
Conversation
|
@jonschlinkert @danez , Did you get a chance to have a look? |
|
I wonder why you didn't dispute the claim. I admit that using unset({}, '__proto__.toLocaleString')
unset(Object.prototype, 'toLocaleString')They could complain about Object.assign(({})['__proto__'], { toString: undefined })
Object.assign(Object.prototype, { toString: undefined })Except for the obj = { constructor: { fixed: true } }
unset(obj, 'constructor.fixed')I think that reports from Mitre, Veracode, Snyk and other companies, which base their business on reporting vulnerabilities, should be validated more rigorously. In any case, this is about your package and you can decide about its interface an implementation, hopefully freely and not after blackmailing ;-) But strictly speaking, this was a breaking change and you released it as a patch version! |
Following up on #11, this PR aims to fix the Nexus IQ alerts.
Hopefully, it would fix this report: https://huntr.dev/bounties/1-npm-unset-value/
(the fix is heavily inspired by the code on your other repo set-values)
Let me know if you have any comments!