[6.1] Fix workflow graph strings and assets#47248
Merged
tecpromotion merged 5 commits intojoomla:6.1-devfrom Mar 13, 2026
Merged
[6.1] Fix workflow graph strings and assets#47248tecpromotion merged 5 commits intojoomla:6.1-devfrom
tecpromotion merged 5 commits intojoomla:6.1-devfrom
Conversation
ef8220e to
6c3b5f7
Compare
richard67
reviewed
Feb 27, 2026
Co-authored-by: Richard Fath <[email protected]>
Member
|
@Vikash-Kumar-23 When GitHub shows that the branch is not up to date, it does not need to use the branch update button every time. It is only a problem if there are conflicts shown, which is not the case here. SO no need to use the branch update button all the time. |
Contributor
|
@Dileepadari can you please check this PR. Thanks. |
Contributor
|
The workflow graph scripts are required only when workflows are enabled. Tested and confirmed that after this change the scripts and styles are no longer included unnecessarily. Thanks @Vikash-Kumar-23 for the pr. |
Contributor
|
I have tested this item ✅ successfully on de12316 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47248. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on de12316 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47248. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47248. |
Contributor
|
Thanks @Vikash-Kumar-23 and all testers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #47224
Summary of Changes
Testing Instructions
Install Joomla 6.1-dev.
Go to Content -> Articles -> Options.
Set Enable Workflows to No.
Open any article for editing.
View the page source (Ctrl+U) and search for workflow-graph.
Result: No assets or strings should be found.
Return to Options and set Enable Workflows to Yes.
Refresh the article edit page and view source again.
Result: workflow-graph-client assets should now be present, confirming the feature still works when enabled.
Actual result BEFORE applying this Pull Request
Even if workflow_enabled is off :
Expected result AFTER applying this Pull Request
if workflow_enabled is off:
if workflow_enabled is on:
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed