fix types according with ultradom types#640
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 144 144
Branches 44 44
=====================================
Hits 144 144Continue to review full report at Codecov.
|
frenzzy
reviewed
Mar 6, 2018
| children: VNodeChild<object | null>[] | ||
| export interface VNode<Attributes = {}> { | ||
| nodeName: string | ||
| attributes?: Attributes |
Contributor
There was a problem hiding this comment.
but attributes are not optional, they are required, isn't it?
maybe key is optional...
Contributor
There was a problem hiding this comment.
I know they can be null but I’m not sure if they can be absent entirely.
Owner
There was a problem hiding this comment.
h(nodeName, null, null)... is okay.
But
{
nodeName, attributes: null, children: null
}
... is not.
Contributor
There was a problem hiding this comment.
Ah, so the hcreateNode function handles that for you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.