This repository was archived by the owner on May 26, 2020. It is now read-only.
Added tests to validate JWT Auth compatibility with OAuth2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marccerrato thank you so much for this! I'll try and take a closer look today and see what I can come up with. Any other recommendations apart from using something other than "Bearer"? |
|
@jpadilla I think the best and easier solution is to use another keyword, like "JWT", since in the draft (http://tools.ietf.org/html/draft-ietf-oauth-json-web-token-15) is not specified which term to use, and maybe "Bearer" should only be used for OAuth. Another choice, it's to validate the token format to distinguish from the OAuth2 one, but it should require changing the DRF OAuth2Authentication class as well. |
|
I agree with changing the header from "Bearer" to "JWT" |
jpadilla
added a commit
that referenced
this pull request
Jan 22, 2014
Added tests to validate JWT Auth compatibility with OAuth2
This was referenced Aug 26, 2014
|
@marccerrato nice dude |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the tests to validate the compatibility problem between JWT Auth and OAuth2, which I commented on the issue #3.
I have also used
Toxto make it possible to run the tests with the extra requirement ofdjango-oauth2-providerwithout altering the base requirements of the package.