Fix: Don’t force a color transform by default for CYMK images #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default opts overwrote the sane default of NOT transforming CYMK images unless there’s a transformCode set. The default of true rendered the `if`s in line 841 and 880 useless since `this.colorTransform` was always set.
|
Side note: the bug was introduced in #39. |
|
Oh great catch thanks @rluba! Mind adding a test case for this? I think I've created the correct cmyk JPEG to repro (jpeg + cmyk expectation are in fixtures.zip). |
|
Thanks. Yes, your test image was broken before the fix and looks OK with this fix. The colors are slightly off after opening and saving it with jpeg-js, but that’s probably a color profile issue. I’ve seen the same slight difference with my images. |
patrickhulce
approved these changes
Feb 12, 2020
zed-0xff
pushed a commit
to zed-0xff/jpeg-js
that referenced
this pull request
Feb 24, 2023
…s#64) * Fix: Don’t force a color transform by default The default opts overwrote the sane default of NOT transforming CMYK images unless there’s a transformCode set. The default of true rendered the `if`s in line 841 and 880 useless since `this.colorTransform` was always set. * Fix typo * Add test with patrickhulce’s example image BREAKING CHANGE: CMYK images will respect their embedded `transformCode`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the same problem as #23, but instead of RGB images with a
transformCodeof0, I experienced the color problems on CYMK images with such atransformCode.The global default opts overwrote the color-mode dependent default of NOT transforming colors of CYMK images unless there’s a
transformCodeset.The default of
truerendered theifs in line 841 and line 880 useless sincethis.colorTransformwas always set and therefore always overwrote the color-mode dependent defaults in line 837 and line 876.Unfortunately, I can’t provide an example jpeg with CYMK and
transformCode = 0since I’m not allowed to disclose any of the files I work with. 😕 But according to their metadata, they were authored with "Adobe Illustrator CS5.1" in 2015.