-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Fix event delegation with selector-native #2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
- Ignore certain tests that obviously are not supported Fixes jquerygh-1742 Fixes jquerygh-2048
- Ignore certain tests that obviously are not supported - Beefed up the sortOrder, uniqueSort, isXMLDoc, and attr functions Fixes jquerygh-1742 Fixes jquerygh-2048
By the way, I was wrong about this being broken. I was thinking we weren't dealing with the |
...or the new @gibson042's in-jQuery implementation that borrows some ideas from Sizzle but only as much as needed (see jquery/sizzle#293 (comment) for more info). But that's a plan for the next major. |
At some point the DOM |
Until we drop IE 11 (which will happen once we conquer Mars) we need all this parsing logic anyway. |
Or possibly later. Something I like about selector-native is that it doesn't even tokenize the selector, which would be required even in a streamlined engine. Rather than an in-jQuery implementation, I'd prefer to see a new version of Sizzle that drops all polyfills (for native selectors) and POS handling, and just manipulates the selector into something that can first go through qsa or matchesSelector, then filtered. Regardless, it won't be for 3.0, and it's something we can discuss later when the time comes. |
When event delegation started using Sizzle's seed handling for scoped matches, it broke event delegation when selector-native replaced Sizzle. Worse comes to worse, we can just defer to matchesSelector and eat the scope issue.
The text was updated successfully, but these errors were encountered: