fix grunt-compare-size dependency to v0.2.0 #1102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the problem and agree it was a mistake to have any greater-than dependencies in the file at all. It worries me to think about |
|
@dmethvin The proper way to create a new tag for 1.8.3 would be to add a build version, e.g., 1.8.3+1. You can also use letters and dashes in the build identifier if you want. |
|
worksforme, i'll update this tomorrow. |
|
Landed at 4b2e979 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking out the tag 1.8.3 and installing dependencies via
npm installleads to v3.0.1 of grunt-compare-size. However, the last compatible version of grunt-compare-size is v.0.2.0.Please merge this small change in package.json and update the jquery tag 1.8.3, otherwise it's not possible to build jquery from scratch using this tag.