Add recommended main field to bower.json to help build tools find the source.
#1516
Conversation
…he source. This makes it possible for build tools such as [Webpack](https://github.com/webpack/webpack) to [resolve the package using bower.json.](webpack/webpack#143 (comment)) [bower.json specification](https://github.com/bower/bower.json-spec#main) recommends adding this field. Also removed bower.json from the ignore list in bower.json, to prevent it from being removed when the package is installed, so it can be used for this purpose.
|
+1 grunt-bower-install needs this as well. Thanks for the PR @fson! |
|
I think it might be better to only add this property in tagged commits where the distributed files are present. |
|
@timmywil I think thats fine, but it looks like some tags are missing the directive. See Just for reference, the jquery bower package was pointing to https://github.com/components/jquery. This is how the previous json file was configured: https://github.com/components/jquery/blob/master/bower.json |
|
You're right, they are currently missing the main property, but I'd like to see the addition in the release script. I'm working on this. |
|
Tags 1.11.0 and 2.1.0 should now be fixed. |
|
Thank you! |
|
O, no, another problem. I don't think you wanted to ignore https://github.com/jquery/jquery/blob/master/bower.json#L15 When you bower install the package, the |
|
You're right! I meant to do that. One second. |
|
Done. |
|
Working great. Thanks again @timmywil |
|
Glad it's working. Thanks for confirming for me. |
… property Fixes #14798 Close jquerygh-1516 Ref jquerygh-1338
Ref #14798 Ref jquerygh-1516 Ref jquerygh-1338
… property Fixes #14798 Close jquerygh-1516 Ref jquerygh-1338 Conflicts: bower.json
Ref #14798 Ref jquerygh-1516 Ref jquerygh-1338
This makes it possible for build tools such as Webpack to resolve the package using bower.json.
bower.json specification recommends adding this field.
Also removed
bower.jsonfrom the ignore list in bower.json,to prevent it from being removed when the package is installed,
so it can be used for this purpose.