Avoid sed due to portability issues between GNU and BSD versions #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 No crazy Unicode hackery, no Uglify.js monkey-patching. Tested on OS X 10.6.6 with Node.js 0.3.7; works flawlessly. |
|
Landed 2862f58 Thanks. This is what I should have come up with in the first place |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the recent commit (ba43d37) to fix
sedcaused the semicolon to disappear from the end of the finaljquery.min.js. Looking further into it, it appears that the Mac OS X (10.6.6) version ofseddoesn't support the.\+syntax. I tried replacing it with.\{1,\}only to discover that the BSDsedalso doesn't support inserting newline characters in the replacement string. It simply adds an'n'.To avoid these issues, this pull request's commit replaces the
sedcall with a simple post-compile script that usesnode.