Core: Drop support for Edge Legacy (i.e. non-Chromium Microsoft Edge) #4792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
commented
Sep 21, 2020
| @@ -543,7 +543,7 @@ jQuery.extend( { | |||
| if ( s.crossDomain == null ) { | |||
| urlAnchor = document.createElement( "a" ); | |||
|
|
|||
| // Support: IE <=8 - 11+, Edge 12 - 17 only | |||
| // Support: IE <=8 - 11+ | |||
There was a problem hiding this comment.
I removed mentions of Edge from support comments as well. Among other things, this is because many IE workarounds are now hidden behind an isIE check so a support comment mentioning Edge would be confusing as Edge wouldn't execute that code.
IE is quite special here as that's the only browser which we detect as a browser to work around its bugs instead of running support tests.
This was referenced Sep 21, 2020
|
Travis fails because tests on Firefox ESR are run on version 68 at the moment. That version doesn't support the |
mgol
commented
Sep 21, 2020
Comment on lines
+7
to
+8
| return jQuery.contains( elem.ownerDocument, elem ) || | ||
| elem.getRootNode( composed ) === elem.ownerDocument; |
There was a problem hiding this comment.
Reorganizing the definitions decreased the gzipped size a bit.
timmywil
reviewed
Sep 21, 2020
timmywil
approved these changes
Sep 21, 2020
Also, restrict some workarounds that were applied unconditionally in all browsers to run only in IE now. This slightly increases the size but reduces the performance burden on modern browsers that don't need the workarounds. Also, clean up some comments & remove some obsolete workarounds. Fixes jquerygh-4568
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 29, 2023
Both IE & Edge Legacy need the workaround of calling `setDocument()` in an `unload` handler to avoid "permission denied" errors. However, due to not being possible to feature-detect this issue, the handler has been applied in all browsers for windows different than the one in which jQuery was loaded. jQuery 4.0, which drops Edge Legacy support, guards this workaround with a `document.documentMode` check. This won't work in the 3.x line due to still supporting Edge Legacy but we can check for `document.documentElement.msMatchesSelector` instead as that API is supported in IE 9+ and all Edge Legacy versions. Fixes jquerygh-5281 Ref jquerygh-4792
1 task
mgol
added a commit
that referenced
this pull request
Jul 10, 2023
Both IE & Edge Legacy need the workaround of calling `setDocument()` in an `unload` handler to avoid "permission denied" errors. However, due to not being possible to feature-detect this issue, the handler has been applied in all browsers for windows different than the one in which jQuery was loaded. jQuery 4.0, which drops Edge Legacy support, guards this workaround with a `document.documentMode` check. This won't work in the 3.x line due to still supporting Edge Legacy but we can check for `document.documentElement.msMatchesSelector` instead as that API is supported in IE 9+ and all Edge Legacy versions. Fixes gh-5281 Closes gh-5282 Ref gh-4792
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drop support for EdgeHTML (i.e. non-Chromium Microsoft Edge).
Also, restrict some workarounds that were applied unconditionally in all
browsers to run only in IE now. This slightly increases the size but reduces
the performance burden on modern browsers that don't need the workarounds.
Also, clean up some comments & remove some obsolete workarounds.
Fixes gh-4568
-255 bytes 🎉
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com