Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Feb 8, 2024

Fixes gh-5411

Summary

The factory files were not distributed as they needed to be added to the distFiles list.

Checklist

@timmywil timmywil requested a review from mgol February 8, 2024 22:16
@timmywil timmywil added this to the 4.0.0 milestone Feb 8, 2024
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see files dist-module/jquery.node-module-wrapper.js & dist-module/jquery.node-module-wrapper.slim.js are not on the list and yet they are included in jquery-dist. How are they copied to jquery-dist?

@timmywil
Copy link
Member Author

timmywil commented Feb 9, 2024

See the extras array in dist.js

@timmywil timmywil merged commit 1a324b0 into jquery:main Feb 9, 2024
@timmywil timmywil deleted the release-dist branch February 9, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

The jquery.factory.js bundle is missing in the npm package in the 4.0.0-beta release
2 participants