Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Mar 10, 2024

Summary

3.x version of #5440

  • migrate more uses of fs.promises; use node: protocol. I had missed a lot because my vs code search index was off.
  • fix size comparison for slim files when the branch is dirty. I fixed this by preferring +slim. to + in the regex. It was only matching on the latter even for the slim file.
  • make compare size cache readable for manual edits. This is in lieu of more complicated options added to the build command. It's not hard to just edit the JSON, but it might as well be readable.
  • Fix worker restarts for when a browser fails the acknowledgement test (I just broke this in Tests: add --hard-retries option to test runner #5439 )

Checklist

@timmywil timmywil added the Build label Mar 10, 2024
@timmywil timmywil added this to the 3.7.2 milestone Mar 10, 2024
@timmywil timmywil requested a review from mgol March 10, 2024 16:31
@timmywil timmywil force-pushed the build-updates-3.x branch 2 times, most recently from 7b1be07 to 40bd8a4 Compare March 11, 2024 14:30
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 11, 2024
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 11, 2024
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 11, 2024
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 11, 2024
timmywil added a commit to timmywil/jquery that referenced this pull request Mar 11, 2024
@timmywil timmywil force-pushed the build-updates-3.x branch from 40bd8a4 to fe7fd76 Compare March 11, 2024 14:52
@timmywil timmywil force-pushed the build-updates-3.x branch from fe7fd76 to b278780 Compare March 11, 2024 15:05
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same comment as at #5440 (review)

@timmywil timmywil merged commit d926cca into jquery:3.x-stable Mar 11, 2024
@timmywil timmywil deleted the build-updates-3.x branch March 11, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants