Tests: Switch to an updated fork of promises-aplus-tests #5559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream package has been unmaintained for years, with dependencies with long-reported security issues. Switching to a fork allows to resolve all the security reports against the jQuery development environment. The fork is maintained by @mgol and has the following changes: 1. The `underscore` dependency has been removed. 2. `sinon` has been updated from v1 to v19. 3. `mocha` has been updated from v2 to v10. Changes to the source are minimal; it will be easy to rebase the fixes if the upstream package is ever updated. In addition to the above, the `q` dependency has been removed. It's been added in jquerygh-1996 but never really used.
mgol
added a commit
that referenced
this pull request
Sep 30, 2024
The upstream package has been unmaintained for years, with dependencies with long-reported security issues. Switching to a fork allows to resolve all the security reports against the jQuery development environment. The fork is maintained by @mgol and has the following changes: 1. The `underscore` dependency has been removed. 2. `sinon` has been updated from v1 to v19. 3. `mocha` has been updated from v2 to v10. Changes to the source are minimal; it will be easy to rebase the fixes if the upstream package is ever updated. In addition to the above, the `q` dependency has been removed. It's been added in gh-1996 but never really used. Closes gh-5559 (cherry picked from commit 559bc5a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The upstream package has been unmaintained for years, with dependencies with long-reported security issues. Switching to a fork allows to resolve all the security reports against the jQuery development environment.
The fork is maintained by @mgol and has the following changes:
underscoredependency has been removed.sinonhas been updated from v1 to v19.mochahas been updated from v2 to v10.Changes to the source are minimal; it will be easy to rebase the fixes if the upstream package is ever updated.
In addition to the above, the
qdependency has been removed. It's been added in gh-1996 but never really used.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com