Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Docs: Update CONTRIBUTING.md #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Docs: Update CONTRIBUTING.md #5564

merged 1 commit into from
Oct 14, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 9, 2024

Summary

While trying to address jquery/jquery-migrate#486 & jquery/jquery-migrate#492 I noticed issues in the jQuery contributing guide itself.

Changes:

  1. Update the link to "help wanted" or "patch welcome" issues to only include open ones.
  2. Replace info about the jQuery Forum & IRC with Matrix & Stack Overflow.
  3. Update the test reduction WebKit blog post link.
  4. Update the Git clone instructions to not rely on the legacy git:// protocol.
  5. Fix a few typos.

Checklist

@mgol mgol self-assigned this Oct 9, 2024
Changes:
1. Update the link to "help wanted" or "patch welcome" issues to only include
   open ones.
2. Replace info about the jQuery Forum & IRC with Matrix & Stack Overflow.
3. Update the test reduction WebKit blog post link.
4. Update the Git clone instructions to not rely on the legacy `git://`
   protocol.
5. Fix a few typos.
mgol added a commit to mgol/jquery-migrate that referenced this pull request Oct 9, 2024
Migrate the jQuery Core CONTRIBUTING.md, applying Migrate-specific changes

Fixes jquerygh-486
Fixes jquerygh-492
Ref jquery/jquery#5564
@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Oct 13, 2024
@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Oct 13, 2024
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating.

@mgol mgol removed the Needs review label Oct 14, 2024
@mgol mgol merged commit 4ef25b0 into jquery:main Oct 14, 2024
15 checks passed
@mgol mgol deleted the contributing branch October 14, 2024 16:40
mgol added a commit that referenced this pull request Oct 14, 2024
Changes:
1. Update the link to "help wanted" or "patch welcome" issues to only include
   open ones.
2. Replace info about the jQuery Forum & IRC with Matrix & Stack Overflow.
3. Update the test reduction WebKit blog post link.
4. Update the Git clone instructions to not rely on the legacy `git://`
   protocol.
5. Fix a few typos.

Closes gh-5564

(cherry picked from commit 4ef25b0)
@mgol
Copy link
Member Author

mgol commented Oct 14, 2024

Landed on main in 4ef25b0 and on 3.x-stable in d41f0cd.

@mgol mgol added this to the 3.7.2 milestone Oct 14, 2024
mgol added a commit that referenced this pull request Oct 14, 2024
@mgol
Copy link
Member Author

mgol commented Oct 14, 2024

There was a little followup for 4.0 at #5567.

mgol added a commit to mgol/jquery-migrate that referenced this pull request Oct 14, 2024
Migrate the jQuery Core CONTRIBUTING.md, applying Migrate-specific changes.

Fixes jquerygh-486
Fixes jquerygh-492
Ref jquery/jquery#5564
mgol added a commit to jquery/jquery-migrate that referenced this pull request Oct 28, 2024
Migrate the jQuery Core CONTRIBUTING.md, applying Migrate-specific changes.

Fixes gh-486
Fixes gh-492
Closes gh-541
Ref jquery/jquery#5564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants