-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Docs: Update CONTRIBUTING.md #5564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Update the link to "help wanted" or "patch welcome" issues to only include open ones. 2. Replace info about the jQuery Forum & IRC with Matrix & Stack Overflow. 3. Update the test reduction WebKit blog post link. 4. Update the Git clone instructions to not rely on the legacy `git://` protocol. 5. Fix a few typos.
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Oct 9, 2024
Migrate the jQuery Core CONTRIBUTING.md, applying Migrate-specific changes Fixes jquerygh-486 Fixes jquerygh-492 Ref jquery/jquery#5564
This was referenced Oct 9, 2024
timmywil
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating.
mgol
added a commit
that referenced
this pull request
Oct 14, 2024
Changes: 1. Update the link to "help wanted" or "patch welcome" issues to only include open ones. 2. Replace info about the jQuery Forum & IRC with Matrix & Stack Overflow. 3. Update the test reduction WebKit blog post link. 4. Update the Git clone instructions to not rely on the legacy `git://` protocol. 5. Fix a few typos. Closes gh-5564 (cherry picked from commit 4ef25b0)
There was a little followup for |
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Oct 14, 2024
Migrate the jQuery Core CONTRIBUTING.md, applying Migrate-specific changes. Fixes jquerygh-486 Fixes jquerygh-492 Ref jquery/jquery#5564
mgol
added a commit
to jquery/jquery-migrate
that referenced
this pull request
Oct 28, 2024
Migrate the jQuery Core CONTRIBUTING.md, applying Migrate-specific changes. Fixes gh-486 Fixes gh-492 Closes gh-541 Ref jquery/jquery#5564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While trying to address jquery/jquery-migrate#486 & jquery/jquery-migrate#492 I noticed issues in the jQuery contributing guide itself.
Changes:
git://
protocol.Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com