Core: Formally deprecate push/sort/splice #5653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we inlined Sizzle into jQuery, we haven't been actually using these three methods internally. Therefore, we could add deprecation warnings in Migrate 3.x for them with jQuery 3.7.0 or newer - both 3.7.0 & 3.7.1 pass all the tests with them removed (while 3.6.4 does not). Some basic tests were added as well.
|
If we decided to land this, the next version would probably have to be 3.8.0, not 3.7.2. But it's been 1.5 years since 3.7.1 and |
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Apr 8, 2025
|
Migrate PR: jquery/jquery-migrate#568 |
timmywil
approved these changes
Apr 14, 2025
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
May 4, 2025
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we inlined Sizzle into jQuery, we haven't been actually using these three
methods internally. Therefore, we could add deprecation warnings in Migrate 3.x
for them with jQuery 3.7.0 or newer - both 3.7.0 & 3.7.1 pass all the tests
with them removed (while 3.6.4 does not).
Some basic tests were added as well.
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com