Data: clear hasDataAttrs on full .removeData() call#5849
Open
sawirricardo wants to merge 1 commit into
Open
Conversation
The hasDataAttrs flag was not cleared when .removeData() was called without a key, preventing subsequent .data() calls from re-reading HTML5 data-* attributes as documented. Fixes jquerygh-5751
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-5751
The
hasDataAttrsprivate flag was not cleared when.removeData()was called without a key argument. This prevented subsequent.data()calls from re-reading HTML5data-*attributes, contrary to the documented behavior:Reproduction
Fix
Clear
dataPriv'shasDataAttrsflag when.removeData()is called without a specific key (full data removal). When a key is passed, the flag is left intact since individual key removal should not trigger a full data-attr re-scan.Test plan
Added QUnit test
.removeData() clears hasDataAttrs so data-* attributes are re-read (gh-5751)verifying the documented behavior.