CSS: Add tests for negative padding and borderWidth#5850
Open
sawirricardo wants to merge 1 commit into
Open
Conversation
Negative padding and borderWidth values are clipped to zero by setPositiveNumber. Add explicit test coverage for this behavior across all four sides for both padding and borderWidth properties, including em units and numeric (unitless) values. Closes jquerygh-2700
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for negative padding and borderWidth values being clipped to zero by
setPositiveNumber.Negative padding and borderWidth values should be clipped to zero (they are not valid CSS). The
setPositiveNumberfunction enforces this viaMath.max(0, ...), but there were no explicit tests covering this behavior for padding and border properties.Test coverage
padding-top,padding-right,padding-bottom,padding-leftwith negative values (-10px,-5px,-1em,-20numeric)border-*-widthproperties with negative values (-5px)0pxCloses gh-2700