Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fixes #12282, sometimes IE10 and lower have document.readyState == "interactive" way too early #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikesherov wants to merge 1 commit into from
Closed

fixes #12282, sometimes IE10 and lower have document.readyState == "interactive" way too early #901

mikesherov wants to merge 1 commit into from

Conversation

@mikesherov
Copy link
Member

@mikesherov mikesherov commented Aug 19, 2012

With tests! Conclusive, repeatable proof!

Running "compare_size:files" (compare_size) task
Sizes - compared to master
    258460      (+121)  dist/jquery.js                                         
     92618        (-7)  dist/jquery.min.js                                     
     33134        (+1)  dist/jquery.min.js.gz

rwaldron
rwaldron reviewed Aug 19, 2012
View reviewed changes
src/core.js
Copy link
Member

@rwaldron rwaldron Aug 19, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's gotta be a better way

Copy link
Member Author

@mikesherov mikesherov Aug 19, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all ears.

Copy link
Member Author

@mikesherov mikesherov Aug 20, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently no good way I can see to detect that IE9 and IE10 have fired interactive too early. Although, now that there's this repeatable test case, perhaps you can poke around too. For now, this seems to be the only way (although I agree it's dirty).

@dmethvin dmethvin closed this in 0f553ed Aug 20, 2012
@peterschmidler
Copy link

peterschmidler commented Aug 21, 2012

Thanks mike! I was getting gray hairs by this one...

@mikesherov
Copy link
Member Author

mikesherov commented Aug 21, 2012

@peterschmidler Thanks. Keeping my fingers crossed that nothing pops up in chrome or Firefox!

@danjagnow
Copy link

danjagnow commented Aug 22, 2012

This fix was just what I needed after upgrading to 1.8.0. Looking forward to seeing it in a stable jQuery release (and NuGet package, in my case). Thanks, Mike!

@shogun70 shogun70 mentioned this pull request Apr 28, 2013
Closed
mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@mikesherov @dmethvin
Fix #12282. IE has premature .readyState == "interactive". Close jque…
e0c6b4b 
…rygh-901.
@nvenegas nvenegas mentioned this pull request Jun 19, 2015
Closed
nvenegas pushed a commit to skatejs/skatejs that referenced this pull request Jun 19, 2015
ready: Use readyState === 'complete' since IEs can fire 'interactive'…
e0268ed 
… early.

See jquery/jquery#901
@mbeenen mbeenen mentioned this pull request Sep 1, 2016
Closed
ihilt added a commit to ihilt/youmightnotneedjquery that referenced this pull request May 18, 2017
@ihilt
IE9+ changes readyState prematurely
3907dbb 
Change readyState example to handle IE9+ weirdness.

See pull request: jquery/jquery#901
This was referenced May 18, 2017
Closed
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikesherov @peterschmidler @danjagnow @rwaldron @dmethvin