Fix missing dependency declarations (accused by sprockets_better_errors gem). #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls::Helper::DependencyError), for pngs missing dependency declaration in ui theme. Asset depends on 'jquery-ui/ui-bg_flat_75_ffffff_40x100.png' to generate properly but has not declared the dependency Please add: `//= depend_on_asset "jquery-ui/ui-bg_flat_75_ffffff_40x100.png"` to '/Users/lu/.rvm/gems/ruby-2.0.0-p353@shiftit_rails3.2.16/gems/jquery-ui-rails-4.1.0/app/assets/stylesheets/jquery.ui.theme.css.erb'
|
Please see my response in #59 (comment). Let's continue the discussion there for now. |
rake aborted! "\xC3" on US-ASCII /Users/lu/.rvm/gems/ruby-2.0.0-p0/gems/json-1.8.1/lib/json/common.rb:155:in `encode' /Users/lu/.rvm/gems/ruby-2.0.0-p0/gems/json-1.8.1/lib/json/common.rb:155:in `initialize' /Users/lu/.rvm/gems/ruby-2.0.0-p0/gems/json-1.8.1/lib/json/common.rb:155:in `new' /Users/lu/.rvm/gems/ruby-2.0.0-p0/gems/json-1.8.1/lib/json/common.rb:155:in `parse' /Users/lu/jquery-ui-rails/Rakefile:38:in `block in map_dependencies' /Users/lu/jquery-ui-rails/Rakefile:37:in `each' /Users/lu/jquery-ui-rails/Rakefile:37:in `map_dependencies' /Users/lu/jquery-ui-rails/Rakefile:54:in `<top (required)>' /Users/lu/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `eval' /Users/lu/.rvm/gems/ruby-2.0.0-p0/bin/ruby_noexec_wrapper:14:in `<main>'
|
Hi @joliss , I modified my pull request to automatically generate the missing dependency declarations in the Modified asset files are already generated using the new method. I also added an encoding to the Rakefile since at least here ( |
joliss
added a commit
that referenced
this pull request
Dec 15, 2013
Fix missing dependency declarations (accused by sprockets_better_errors gem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded my sprockets to be able to install the
sprockets_better_errorsgem, which is great for detecting when we are doing something wrong in the rails asset pipeline.This gem is missing dependency declarations for the pngs referenced in the
app/assets/stylesheets/jquery.ui.theme.css.erbfile.This pull request adds the necessary dependency declarations.
For future reference
sprockets 2.2.2.backport2,sprockets-rails 2.0.0.backport1andrails 3.2.16.Thank you for maintaining a great gem!