Fixed bug #697: Remote validation uses wrong error messages #1028
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denisson test( "Fix #697: remote validation uses wrong error messages", function( assert ) {
var e = $( "#username" ),
done1 = assert.async(),
done2 = assert.async(),
done3 = assert.async(),
v = $( "#userForm" ).validate( {
rules: {
username: {
required: true,
remote: {
url: "users.php"
}
}
},
messages: {
username: {
remote: $.validator.format( "{0} in use" )
}
}
} );
$( "#userForm" ).valid();
e.val( "Peter" );
v.element( e );
setTimeout( function() {
equal( v.errorList[ 0 ].message, "Peter in use" );
done1();
e.val( "something" );
v.element( e );
e.val( "Peter" );
v.element( e );
setTimeout( function() {
equal( v.errorList[ 0 ].message, "Peter in use" );
done2();
e.val( "asdf" );
v.element( e );
setTimeout( function() {
equal( v.errorList[ 0 ].message, "asdf in use", "error message should be updated" );
done3();
} );
} );
} );
} );NB: You should also rebase the PR on top of
|
|
@denisson |
|
@Arkni |
|
@denisson any update on this? |
|
I am having problems with commitplease. I guess I'm doing something wrong. On Tue, Dec 22, 2015 at 11:25 AM, Brahim Arkni [email protected]
|
|
You have to start your commit message with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't break any existing unit test, but there is no additional tests. It would be great if somebody could create these tests, because I don't know how to do it.