Patch 3 #676
Merged
Patch 3 #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… right after. Enables chaining using the onClose callback method
|
Hey Alex, what are your thoughts on this. I think this is valid. onClose should be happening after everything is closed. If user needs to do something before then, it should be done with onBeforeClose. |
|
Alex and Tero, your thoughts please. If no response, I'll probably end up accepting this pull request for 1.2.8. |
duclet
pushed a commit
that referenced
this pull request
Mar 25, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a mask currently open and close and need another opened right after. Enables chaining using the onClose callback method