Merge branch 'hotfix/setex_long_expires'

michael-grunder · michael-grunder · commit 00233a3f91fe · 2013-10-04T10:37:45.000-07:00
Incorporate @zined and @s0enke commits to properly handle long timeout values and not overrun our buffer. Addresses phpredis#385
diff --git a/redis.c b/redis.c
@@ -890,7 +890,7 @@ PHP_METHOD(Redis, set) {
                                           val, val_len, set_type, 2);
     } else if(expire > 0) {
         /* Backward compatible SETEX redirection */
-        cmd_len = redis_cmd_format_static(&cmd, "SETEX", "sds", key, key_len,
+        cmd_len = redis_cmd_format_static(&cmd, "SETEX", "sls", key, key_len,
                                           expire, val, val_len);
     } else {
         /* SET <key> <value> */
@@ -932,7 +932,7 @@ PHPAPI void redis_generic_setex(INTERNAL_FUNCTION_PARAMETERS, char *keyword) {
 
     val_free = redis_serialize(redis_sock, z_value, &val, &val_len TSRMLS_CC);
 	key_free = redis_key_prefix(redis_sock, &key, &key_len TSRMLS_CC);
-    cmd_len = redis_cmd_format_static(&cmd, keyword, "sds", key, key_len, expire, val, val_len);
+    cmd_len = redis_cmd_format_static(&cmd, keyword, "sls", key, key_len, expire, val, val_len);
     if(val_free) efree(val);
     if(key_free) efree(key);
 
diff --git a/tests/TestRedis.php b/tests/TestRedis.php
@@ -408,6 +408,13 @@ public function testSetNX() {
 	    $this->assertTrue($this->redis->get('key') === '42');
     }
 
+    public function testExpireAtWithLong() {
+        $longExpiryTimeExceedingInt = 3153600000;
+        $this->redis->delete('key');
+        $this->assertTrue($this->redis->setex('key', $longExpiryTimeExceedingInt, 'val') === TRUE);
+        $this->assertTrue($this->redis->ttl('key') === $longExpiryTimeExceedingInt);
+    }
+
     public function testIncr()
     {
         $this->redis->set('key', 0);

Original file line number	Diff line number	Diff line change
`@@ -408,6 +408,13 @@ public function testSetNX() {`
`408`	`408`	`$this->assertTrue($this->redis->get('key') === '42');`
`409`	`409`	`}`
`410`	`410`
	`411`	`+ public function testExpireAtWithLong() {`
	`412`	`+ $longExpiryTimeExceedingInt = 3153600000;`
	`413`	`+ $this->redis->delete('key');`
	`414`	`+ $this->assertTrue($this->redis->setex('key', $longExpiryTimeExceedingInt, 'val') === TRUE);`
	`415`	`+ $this->assertTrue($this->redis->ttl('key') === $longExpiryTimeExceedingInt);`
	`416`	`+ }`
	`417`	`+`
`411`	`418`	`public function testIncr()`
`412`	`419`	`{`
`413`	`420`	`$this->redis->set('key', 0);`