Thanks to visit codestin.com
Credit goes to github.com

Skip to content

let setex properly handle long expire values #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

let setex properly handle long expire values #385

wants to merge 2 commits into from

Conversation

zined
Copy link
Contributor

@zined zined commented Oct 4, 2013

adjust the format string passed to redis_cmd_format_static() to properly handle long int, in order to prevent integer overflows resulting in negative expire times passed to redis.

cc/ @s0enke

zined and others added 2 commits October 4, 2013 15:07
@zined
let setex properly handle long expire values
f6fb12f 
adjust the format string passed to redis_cmd_format_static() to
properly handle long int, in order to prevent integer overflows
resulting in negative expire times passed to redis.
regression test for: setex properly handles long expire values
4f5c0e4
@nicolasff
Copy link
Member

Looks good, thanks! I'll try to merge it this week.

michael-grunder added a commit that referenced this pull request Oct 4, 2013
@michael-grunder
Merge branch 'hotfix/setex_long_expires'
00233a3 
Incorporate @zined and @s0enke commits to properly handle long timeout
values and not overrun our buffer.

Addresses #385
@michael-grunder
Copy link
Member

Merged guys, thanks!

Cheers,
Mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zined @nicolasff @michael-grunder