Fix inconsistency in #5837 #6360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d26e74c to
7fcca42
Compare
|
Seems good to me, and we should probably try to move away from using ByteList.toString since it is confusing that it returns a raw ISO-8859-1 string regardless of the encoding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5837, only
getSymbol(ByteList bytes, boolean hard)method was modified, and its similar method,getSymbol(ByteList bytes, ObjBooleanConsumer<RubySymbol> handler, boolean hard)was not modified.I think the method has a potential bug, so I fixed it.