Re-implement Zlib::GzipReader and Zlib::GzipWriter with jzlib. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* using JZlib 1.1.0
build_lib/jzlib-1.1.0.jar is built from
https://github.com/ymnk/jzlib/tree/1.1.0
* working around JRUBY-6073 (61633af)
* GzipReader will throw appropieate exceptions for broken input. (1cd2f52)
* NoFooter if not enough trailer data exits,
* CRCError if incorrect checksum data is found,
* LengthError if incorrect length data is found,
* GzipFile::Error if header is broken or EOF is countered before trailer,
* DataError if invalid compression data is found.
* Note that the previous JRuby had thrown IOError instead of DataError.
* Fix 'Zlib::Inflate#<< properly handles incomplete data ERROR' on RubySpec. (710dbba)
* Support Zlib::File:Error#input (41eff81)
* Since Ruby 1.9, Zlib::File:Error#input has been introduced.
According to the source code of CRuby, it will be setted at the failure
in parsing the gzip header.
* Support some methods additionaly (90dc869)
* GzipReader#unused,
* GzipWriter#sync, GzipWriter#sync=
* GzipWriter#flush
|
New Zlib landed on master recently. I'm going to close this request now. |
eregon
added a commit
that referenced
this pull request
Jun 29, 2015
0957d24 add BigDecimal#round special value specs dc36858 Fix spec title e145d75 Fix ARGF.seek spec a27e082 Add spec for Comparable#== without #<=>. 7bbd215 Add a couple specs for constant resolution under module_eval 0afb501 Add spec for resolving constants in Module#module_eval 002731e Fix assertion in Module#module_eval. e450b4a Add spec for redo in a method 63603b5 Add spec for next in a method 09db199 Add spec for spawn redirect to [file,mode]. 071a996 Merge pull request #90 from ruby/time fdf1ced Fix typos f23b1cb Separate Time#<=> specs for millisecond vs microsecond precision b0a3bd4 Remove duplicated assertion 541d1f7 Add spec for ARGF.argv a0a5ca8 Mention it "needs to be reviewed for spec completeness" 4d680ed Remove extra backslash c6558a5 Merge pull request #88 from JuanitoFatas/feature/string-concat-by-spaces 0258119 Update spec description for string literals bca9b5f Add two specs for string concatenations by spaces e9e02f5 Deduplicate example names 4355c35 Merge pull request #87 from JuanitoFatas/string/unicode-normalize 8626efe Fix unicode normalized spec f1de617 Remove unused IO in File#read spec 293f6e4 Fix variable name in FIle#open 62a7b2c Prefer setting autoclose to close + rescue d46d063 mkspec -c String; Copy spec content to mkspec generated spec 50fade7 Apply code review changes 7b6ce1f Try to clarify specs using the map_fd fixture. 7747042 General cleanup of IO specs 850f3ed Reorganize IO#popen specs b8dd40b Make sure the old IO is closed in IO#initialize spec 136b80e Remove 1.8 readlines specs 21b694d No need to check for closed? since IO#read examples never close themselves 39d00ff Just use autoclose=false in socket for_fd specs f58eb48 No need to re-assign @fd in IO.sysopen spec b5aeacb Fix typo in CONTRIBUTING.md 93bc817 Improve notes about mkspec 43685be [core/string] Add String#unicode_normalize specs bb3e13d SVG Travis badge to please the eyes 👀 ea9f106 Reorganize specs for multiple unnamed arguments. c95400b Merge pull request #83 from JuanitoFatas/proc/arguments 5c9b2f1 [Language/block_spec] Add specs to check SyntaxError for block arguments 113e7e6 Merge pull request #85 from ruby/use-standard-require 24d31d1 Standardize require line for unboundmethod/shared/to_s.rb 6f18131 update MSpec 4527d8d The fixture helper now resolves real paths automatically 5aa9134 Fix duplication with CODE_LOADING_DIR 21dae98 Do not use the fixture helper on already expanded path 4c4523c Just check for realpath in spec_helper.rb 4dea397 Resolve realpath to fixture directory in -C spec a03ed0e Have a better check for CODE_LOADING_DIR and realpath a8884b9 Update required MSpec version c1ab544 Update instructions to directly use a MSpec checkout 186300a Remove $SAFE-related specs. b762526 Merge pull request #82 from ruby/fix-ruby-version bc11d67 fixed wrong version of ruby 2b8e36b Merge pull request #81 from ruby/remove-safe3 7c640e2 discarded =3 example with Ruby 2.3 19af98c Improve a bit Array#bsearch_index spec 4e1a9b3 Merge pull request #78 from JuanitoFatas/feature/bsearch_index_spec c5374cd Merge pull request #79 from JuanitoFatas/feature/bundled-with 18dd536 Clearer description of @array.bsearch_index { |x| (1 - x / 4) * (2**100) ea9bd82 Remove specs of break de6124c Add BUNDLED WITH to Gemfile.lock 7732e00 Fix example descriptions and reorganize specs ac55574 Fix ARGF spec for Windows 2cab1f3 Fix syntax errors 0cf2e94 Port Array#bsearch_index spec from ruby/ruby@c64d283 git-subtree-dir: spec/ruby git-subtree-split: 0957d245b6170480c880a62da19a335113cc8c84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_lib/jzlib-1.1.0.jar is built from
https://github.com/ymnk/jzlib/tree/1.1.0
According to the source code of CRuby, it will be setted at the failure
in parsing the gzip header.