Implement block_given? call as optimized instruction #8170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks fcalls to
block_given?
as a custom instruction based onBlockGivenInstr
used by the lighter-weightdefined?(yield)
form.Instead of forcing a caller frame (so that the caller's received block can be accessed downstack), the new logic checks if the target method is the core version and uses
defined?(yield)
logic in that case. When the method is not from JRuby core, then we dispatch normally... but without the caller frame requirement, since only the coreblock_given?
is allowed to have that access. All other call paths leading toblock_given?
continue to use the deoptimized logic, so we are not introducing any new incompatibility.This makes the performance of
block_given?
-calling methods equivalent to those that usedefined?(yield)
and avoids the framing cost in all situations that fcallblock_given?
.Performance is shown through the added benchmark: