Mask internal Ruby backtrace elements like native masking #9154
+38
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating backtraces for `caller`, JRuby maintains compat
with CRuby by replacing all internal native frames with the most
recent external Ruby frame, as illustrated below:
```
$ cx jruby-10.0.2.0 ruby -e "def foo; puts caller(0); end; foo"
-e:1:in 'foo'
-e:1:in '<main>'
```
Up until now, we did not treat internal Ruby sources the same way,
but Ruby 4.0 now does a similar masking of such sources:
JRuby:
```
$ cx jruby-10.0.2.0 ruby -e "def foo; puts caller(0); end; tap { foo }"
-e:1:in 'foo'
-e:1:in 'block in <main>'
<internal:uri:classloader:/jruby/kernel/kernel.rb>:19:in 'tap'
-e:1:in '<main>'
```
CRuby:
```
$ cx 4.0.0 ruby -e "def foo; puts caller(0); end; tap { foo }"
-e:1:in 'Object#foo'
-e:1:in 'block in <main>'
-e:1:in 'Kernel#tap'
-e:1:in '<main>'
```
This patch uses the native masking logic in backtrace building to
also mask internal Ruby source frames, producing a `caller` trace
that matches CRuby:
```
$ ruby -v -e "def foo; puts caller(0); end; tap { foo }"
jruby 10.1.0.0-SNAPSHOT (4.0.0) 2026-01-06 ef3d5d0 OpenJDK 64-Bit Server VM 25+36-LTS on 25+36-LTS +indy +jit [arm64-darwin]
-e:1:in 'foo'
-e:1:in 'block in <main>'
-e:1:in 'tap'
-e:1:in '<main>'
```
Additionally, this patch expands the omission of internal Ruby
frames from `warn` line calculation in the case those methods have
been JIT compiled (this logic was missing before).
headius
added a commit
to headius/jruby
that referenced
this pull request
Jan 6, 2026
At some point, we started including native .java lines in the MRI- formatted trace. This was probably unintended, since MRI-format traces should always follow CRuby's standard of replacing native call frames with the most recent Ruby frame. See jruby#9154 for some discussion of filtering and omitting internal frames (that PR is about Ruby, but the same filtering already applied to native frames used in `caller`). This patch uses the same backtrace gathering logic for the MRI format as it does for `caller`, since in both cases users expect not to see .java frames for internal methods, and now with Ruby 4.0 they will also expect not to see internal Ruby sources.
headius
added a commit
to headius/jruby
that referenced
this pull request
Jan 6, 2026
At some point, we started including native .java lines in the MRI- formatted trace. This was probably unintended, since MRI-format traces should always follow CRuby's standard of replacing native call frames with the most recent Ruby frame. See jruby#9154 for some discussion of filtering and omitting internal frames (that PR is about Ruby, but the same filtering already applied to native frames used in `caller`). This patch uses the same backtrace gathering logic for the MRI format as it does for `caller`, since in both cases users expect not to see .java frames for internal methods, and now with Ruby 4.0 they will also expect not to see internal Ruby sources.
headius
added a commit
to headius/jruby
that referenced
this pull request
Jan 6, 2026
At some point, we started including native .java lines in the MRI- formatted trace. This was probably unintended, since MRI-format traces should always follow CRuby's standard of replacing native call frames with the most recent Ruby frame. See jruby#9154 for some discussion of filtering and omitting internal frames (that PR is about Ruby, but the same filtering already applied to native frames used in `caller`). This patch uses the same backtrace gathering logic for the MRI format as it does for `caller`, since in both cases users expect not to see .java frames for internal methods, and now with Ruby 4.0 they will also expect not to see internal Ruby sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating backtraces for
caller, JRuby maintains compat with CRuby by replacing all internal native frames with the most recent external Ruby frame, as illustrated below:Up until now, we did not treat internal Ruby sources the same way, but Ruby 4.0 now does a similar masking of such sources:
JRuby:
CRuby:
This patch uses the native masking logic in backtrace building to also mask internal Ruby source frames, producing a
callertrace that matches CRuby:Additionally, this patch expands the omission of internal Ruby frames from
warnline calculation in the case those methods have been JIT compiled (this logic was missing before).