Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jonathanrcross
Copy link
Collaborator

@jonathanrcross jonathanrcross commented Mar 27, 2020

  • Update encrypted token to deploy to pypi change condition to python 3.7 python.
  • Switch from disutils to setuptools in setup.py

Unsure if travis is using twine for pypi upload, possibly why it failed on python 2.7?

….7 python. Switch from disutils to setuptools in setup.py
Copy link
Collaborator

@jeffwecan jeffwecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy nice

repo: jrxFive/python-nomad
condition: $TRAVIS_PYTHON_VERSION = "2.7"

condition: $TRAVIS_PYTHON_VERSION = "3.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, the one working example I have of a deploy stage in Travis uses python 3.7 so maybe that's it 🤷‍♂️

@jeffwecan
Copy link
Collaborator

jeffwecan commented Mar 28, 2020

Probably need to retrigger those builds to get the correct status reflected here (if you care to). travis.org was having a bit of an outage yesterday along those lines...

(edit: I went ahead and restarted em)

@jeffwecan
Copy link
Collaborator

jeffwecan commented Mar 28, 2020

Oh! And for what it's worth, when I needed to validate travis + pypi publishing logic in the past, I have used a corresponding entry on https://test.pypi.org/ / https://packaging.python.org/guides/using-testpypi/. In my situation, I added a commit in another branch with a commit to point Travis at the test server url, pushed that up to a fork, and then did a tagged release on the fork to trigger the deploy condition.

Ref: https://docs.travis-ci.com/user/deployment/pypi/#releasing-to-a-self-hosted-pypi

@jonathanrcross
Copy link
Collaborator Author

Yea def need to check out the test pypi! If this doesn't work on merge will do that with a follow up branch...

@jonathanrcross jonathanrcross merged commit 7006cef into master Mar 29, 2020
@jonathanrcross jonathanrcross deleted the setuptools-pypi-secrets branch March 29, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants