-
Notifications
You must be signed in to change notification settings - Fork 77
add support for namespace argument in get_job #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @rndmh3ro, thanks for the PR! I took a look at this and at first glance -- I thought it would work-- but further inspected base.py: python-nomad/nomad/api/base.py Lines 64 to 73 in 0d462bd
which is called by base.py._request as a pre-step before issuing the actual http call: python-nomad/nomad/api/base.py Lines 89 to 96 in 0d462bd
The issue is that if when instantiating a We can change Additionally we should add a couple tests to |
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 78.80% 78.80%
=======================================
Files 26 26
Lines 1203 1203
=======================================
Hits 948 948
Misses 255 255 Continue to review full report at Codecov.
|
hi @rndmh3ro, I worked #120 this should allow us to merge your PR! Ideally if you do have time it be great if you could add a test to verify from the get_jobs level --probably using a mock/responses -- to verify that the querystring is indeed what is being passed. If not we can merge and ill add a test in a follow up. Thanks again! |
Thank you for doing this! |
fixes #118