Codecov Report

Merging #143 (221d0b6) into master (490b148) will increase coverage by 0.02%.
The diff coverage is 81.78%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   91.10%   91.13%   +0.02%     
==========================================
  Files          31       31              
  Lines        1271     1275       +4     
==========================================
+ Hits         1158     1162       +4     
  Misses        113      113              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonathanrcross @jrxFive Hi, I added pylint to the pipeline and fixed the code. I added a lot of exceptions for backward compatibilities except renaming id to _id everywhere. Motivation:

1. It's easy to make mistake with id.
2. Most likely people don't use the named id argument.
3. We have 2.0.0 release and technically it's a major release.

If you have a different opinion, I can remove these changes from MR.

BTW, could you fix the docs polishing?
https://python-nomad.readthedocs.io/en/latest/
It should work automatically as I understand but I don't have access and can't see any error in the process.

Agreed it should have never been shadowed id; yea if we're gonna be doing a major release might as well clean up this code smell.

I'll look into in the doc publishing issue, thanks for letting me know!

@jonathanrcross Could you please review MR, please? :)