Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Update dispatch jobs to support templateprefix and idempotencytoken #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2025
Merged

feat: Update dispatch jobs to support templateprefix and idempotencytoken #171

merged 3 commits into from
Jan 30, 2025

Conversation

aas47
Copy link
Contributor

@aas47 aas47 commented Jan 29, 2025

fixes #158

  • Also dropping older version of Nomad and adding newly introduced ones.
  • bump action versions across different workflows
  • dropping test skip conditions as no longer testing against those Nomad versions

@aas47 aas47 changed the title Update dispatch jobs to support templateprefix and idempotencytoken fact: Update dispatch jobs to support templateprefix and idempotencytoken Jan 29, 2025
@aas47 aas47 changed the title fact: Update dispatch jobs to support templateprefix and idempotencytoken feat: Update dispatch jobs to support templateprefix and idempotencytoken Jan 29, 2025
@aas47
Copy link
Contributor Author

aas47 commented Jan 30, 2025

@jrxFive @jonathanrcross @nikita-b tagging you for review.

@nikita-b nikita-b self-requested a review January 30, 2025 15:19
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.64%. Comparing base (41df869) to head (183ac00).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   90.71%   90.64%   -0.08%     
==========================================
  Files          31       31              
  Lines        1293     1294       +1     
==========================================
  Hits         1173     1173              
- Misses        120      121       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nikita-b
nikita-b approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@nikita-b nikita-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!

@nikita-b nikita-b merged commit 79ae9d9 into jrxFive:master Jan 30, 2025
14 of 15 checks passed
@aas47
Copy link
Contributor Author

aas47 commented Jan 30, 2025

Thank you so much for quick review @nikita-b 🙏
It would be great if there's a new release so this change can be consumed.

@nikita-b
Copy link
Collaborator

@aas47 Hello,
Yes, I'll try to release a new version in a week or more.

@aas47
Copy link
Contributor Author

aas47 commented Jan 30, 2025

@nikita-b awesome! thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-b nikita-b nikita-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parameters IdPrefixTemplate and IdempotencyToken to dispatch_job
2 participants
@aas47 @nikita-b