fix(hasOne): do not create links for undefined or null keys #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc95463 to
ff87b83
Compare
| @@ -193,6 +193,9 @@ utils.addHiddenPropsToTarget(Relation.prototype, { | |||
|
|
|||
| // e.g. user hasMany post via "foreignKey", so find all posts of user | |||
| findExistingLinksByForeignKey (id) { | |||
| if (id === undefined || id === null) { | |||
| return | |||
| } | |||
There was a problem hiding this comment.
or we could rework this method such that it returns an empty array in this case.
|
Issue with Plunkers showing the bug: #380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasOnelinks were being created in cases they should not.undefinedrelatedCollectionwhere theforeignKey === undefined